Bump 0.17.3 rc.0#2215
Merged
Merged
Conversation
Map the internal 0 expiry sentinel back to None when converting Bolt12 mint quotes to API responses, matching the onchain conversion behavior. Add regression coverage for direct and generic Bolt12 quote response paths.
NUT-17 notification payloads are ambiguous without the subscription kind. Quote response shapes overlap and tolerate unknown fields, so shape-based decoding can select the wrong payload variant. Add a kind-aware payload decoder and use it in the wallet subscription client while preserving the existing generic payload deserialization surface for backports. This prevents onchain and custom quote notifications from being decoded as the wrong payload variant.
Detect swap sagas whose inputs are already spent and whose outputs are signed before running setup compensation. Recovery deletes only the orphaned saga record for those finalized swaps, avoiding repeated startup failures while preserving spent proofs and signed outputs. Add a regression test that reinserts a completed swap saga and verifies restart cleanup leaves the finalized swap state intact.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.17.x #2215 +/- ##
===========================================
+ Coverage 72.00% 72.12% +0.11%
===========================================
Files 359 359
Lines 76239 76684 +445
===========================================
+ Hits 54896 55308 +412
- Misses 21343 21376 +33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)