fix: Add SafeArea insets to onboarding screen#406
Open
Egge21M wants to merge 1 commit into
Open
Conversation
| const { t } = useTranslation([NS.common]); | ||
| const [accepted, setAccepted] = useState(false); | ||
| const insets = useSafeAreaInsets(); | ||
| const bottomInset = Platform.OS === "android" ? insets.bottom : 0; |
There was a problem hiding this comment.
That didn't resolve it. I added 60 to the bottomInset and that moved it up enough. That also lets us skip wrapping it in the view below.
const bottomInset = Platform.OS === "android" ? 60 + insets.bottom : 60;
| /> | ||
| <TouchableOpacity | ||
| <View style={[styles.container, { paddingBottom: bottomInset }]}> | ||
| <Onboarding |
There was a problem hiding this comment.
We can remove the view wrap and add
bottomBarHeight={bottomInset}
above the onDone call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.