Skip to content

Update github.com/docker/docker to v28.2.2#65

Open
pijusn-cast wants to merge 2 commits into
mainfrom
pijusn-update-docker-28.2.2
Open

Update github.com/docker/docker to v28.2.2#65
pijusn-cast wants to merge 2 commits into
mainfrom
pijusn-update-docker-28.2.2

Conversation

@pijusn-cast

@pijusn-cast pijusn-cast commented May 20, 2026

Copy link
Copy Markdown

Attempt to update the dependency. It includes some breaking API changes.


Kimchi Summary

What changed

Updates core dependencies including Docker client to v28 and Trivy to v0.64.0, and refactors image config handling to align with Docker's new OCI image spec types.

Why

Docker v28 relocated image configuration types out of the main API package and changed the ImageSave signature, requiring code changes to maintain compatibility.

Key changes

  • go.mod: bumps github.com/docker/docker to v28.2.2, github.com/aquasecurity/trivy to v0.64.0, github.com/google/go-containerregistry to v0.20.6, and refreshes numerous transitive dependencies
  • image/daemon/containerd.go: replaces container.Config with dockerspec.DockerOCIImageConfig from github.com/moby/docker-image-spec; removes nat.PortSet translation for exposed ports
  • image/daemon/image.go: updates imageConfig to map from dockerspec.DockerOCIImageConfig to v1.Config, adapting fields such as ExposedPorts, OnBuild, and ArgsEscaped
  • image/daemon/docker.go: wraps c.ImageSave to strip new variadic options and match the expected func(context.Context, []string) (io.ReadCloser, error) signature

Impact

This change adapts to Docker v28 breaking API changes. The ImageSave call and image inspect structures now use adapter logic to bridge the new Docker OCI spec types. No end-user behavior changes are expected.

@pijusn-cast pijusn-cast self-assigned this May 20, 2026
@kimchi-review

kimchi-review Bot commented May 20, 2026

Copy link
Copy Markdown

Kimchi Code Review

Property Value
Commit 17bd2fb
Author @pijusn-cast
Files changed 0
Review status Completed
Comments 3 (1 info, 2 warning)
Duration 200s

Summary

📊 Review Score: 82/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)

🧪 Tests: no — No tests were added or modified for the ImageSave signature adaptation, the container.Config to DockerOCIImageConfig migration, or the ExposedPorts mapping fix. A dependency bump of this magnitude warrants test coverage for image config translation.

📝 Found 3 issue(s). See inline comments for details.

What to expect

Kimchi will analyze the changes in this pull request and post:

  • A summary of the overall changes
  • Inline comments on specific lines with findings categorized by issue type

The review typically completes within a few minutes. This comment will be updated once the review is ready.

Interact with Kimchi
  • @kimchi review — re-trigger a full review on the latest commit
  • @kimchi summary — regenerate the PR summary
  • @kimchi ignore — skip this PR (no review will be posted)
  • Reply to any inline comment to ask follow-up questions or request clarification
Configuration

Reviews are configured by your organization admin.
Review instructions, excluded directories, and severity thresholds can be adjusted per repository in the Kimchi dashboard.


Powered by Kimchi — AI-powered code review by CAST AI

@kimchi-review kimchi-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Review Score: 82/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)

🧪 Tests: no — No tests were added or modified for the ImageSave signature adaptation, the container.Config to DockerOCIImageConfig migration, or the ExposedPorts mapping fix. A dependency bump of this magnitude warrants test coverage for image config translation.

📝 Found 3 issue(s). See inline comments for details.

Comment thread image/daemon/image.go
Comment thread image/daemon/docker.go
Comment thread image/daemon/image.go Outdated
@pijusn-cast pijusn-cast marked this pull request as ready for review May 25, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant