This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Enable typescript-eslint/explicit-function-return-type#64
Open
tetsuharuohzeki wants to merge 1 commit intocats-oss:masterfrom
Open
Enable typescript-eslint/explicit-function-return-type#64tetsuharuohzeki wants to merge 1 commit intocats-oss:masterfrom
tetsuharuohzeki wants to merge 1 commit intocats-oss:masterfrom
Conversation
tetsuharuohzeki
added
A-config
Contributor
Author
|
We need wait to resolve some problems in the upstream side:
|
|
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
We should annotate types of in/out of functions because programms are built with a bunch of functions. It makes type safe world easy to annotate types of in/out of functions. and we should express the type signature as documentation of their functions. However, this rule is pretty tired for expressions because we use function expression as a callback. Let's disable its case.
tetsuharuohzeki
force-pushed
the
explicit-function-return-type
branch
from
35d8adc to
99a2f5c
Compare
|
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
tetsuharuohzeki
added
A-config/typescript
and removed
A-config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should annotate types of in/out of functions because programms are built with a bunch of functions.
It makes type safe world easy to annotate types of in/out of functions and we should express the type signature as documentation of their functions.
However, this rule is pretty tired for expressions because we use function expression as a callback. Let's disable its case.