Potential fix for code scanning alert no. 83: Poor error handling: empty catch block#32
Merged
Conversation
…pty catch block Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/caveman8080/ACMECertManager/security/code-scanning/83
The best fix is to keep the app behavior non-throwing, but handle the exception explicitly instead of swallowing it. In
src/MainWindow.xaml.cs, insideLog(string message), replace the emptycatch (ObjectDisposedException)block with a low-risk diagnostic action (e.g.,Debug.WriteLine(...)). This avoids recursive logging viaLog(...), avoids UI side effects, and preserves existing functionality (the app continues even if_logManageris disposed).Only one region needs to change:
src/MainWindow.xaml.cs, around lines 75–82 inLog(string message).No new imports are required because
System.Diagnosticsis already imported.Suggested fixes powered by Copilot Autofix. Review carefully before merging.