Add Ctrl+key text navigation and editing shortcuts#2400
Open
TheWireLord wants to merge 2 commits intocc-tweaked:mc-1.20.xfrom
Open
Add Ctrl+key text navigation and editing shortcuts#2400TheWireLord wants to merge 2 commits intocc-tweaked:mc-1.20.xfrom
TheWireLord wants to merge 2 commits intocc-tweaked:mc-1.20.xfrom
Conversation
Added Ctrl+key combinations for text navigation and editing in both the shell and the edit program. **Shell (bios.lua):** - Ctrl+Left/Right: Navigate by words - Ctrl+Backspace: Delete word to the left - Ctrl+Delete: Delete word to the right **Text Editor (edit.lua):** - Ctrl+Left/Right: Navigate by words - Ctrl+Backspace: Delete word to the left - Ctrl+Delete: Delete word to the right - Ctrl+Home: Jump to beginning of file - Ctrl+End: Jump to end of file - Smart menu behavior: Ctrl combos don't interfere with menu system
Contributor
|
You appear to be storing if ctrl was pressed as a flag, have you tested how this code would act if someone (or multiple players) were to press both/multiple ctrl keys and released one? Also would require to check how this changes would interact with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Ctrl+key combinations for text navigation and editing in both the shell and the edit program.
Shell (bios.lua):
Text Editor (edit.lua):