feat: add MongoDB datasource support (#2754)#2911
Open
SaladDay wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@710leo ptal, thx🙏 |
Member
|
@SaladDay Thank you for taking the time to work on this feature! Before we proceed with the code review, I think it would be beneficial to have a more thorough discussion about the product design for this feature in the related issue #2871. There are a few design considerations we should clarify first:
Once we align on the product design and user experience, it will be much easier to determine the best implementation approach. Would you mind sharing your thoughts on these questions in issue #2871? This will help us ensure the implementation meets everyone’s needs and expectations. Looking forward to your input! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it:
This PR adds MongoDB as a new datasource type to Nightingale, enabling users to query and monitor data from MongoDB databases.
Which issue(s) this PR fixes:
Fixes #2754
Special notes for your reviewer:
pool.PoolClientpatternmongodb.for clarity;