Accept 7-byte ControlConfiguration2 payload (BP200G1 fw V72.0) - #104
Open
Pat28 wants to merge 1 commit into
Open
Accept 7-byte ControlConfiguration2 payload (BP200G1 fw V72.0)#104Pat28 wants to merge 1 commit into
Pat28 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a BP200G1 board running firmware V72.0, the ControlConfiguration2 message (\xbf\x2e) is sent with a 7-byte payload instead of the documented 6 bytes, causing BWA::Message.parse to raise InvalidMessage and crash the client's poll loop.
Example raw message: 7e 0c 0a bf 2e 02 00 01 30 00 00 00 da 7e
This widens MESSAGE_LENGTH to a range (6..7), matching the pattern already used elsewhere for messages with variable-length payloads. parse only reads bytes 0–4, so the extra trailing byte on newer boards is simply ignored.