Skip to content

[CDAP-21170] Enable Auto rotation of KMS keys used for secure keys#15961

Merged
adrikagupta merged 1 commit into
developfrom
key-rotation
Jun 23, 2025
Merged

[CDAP-21170] Enable Auto rotation of KMS keys used for secure keys#15961
adrikagupta merged 1 commit into
developfrom
key-rotation

Conversation

@adrikagupta

@adrikagupta adrikagupta commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

To resolve a vulnerability, we need to enable auto rotation, for at most 90 days, of KMS keys which are used to encrypt/decrypt secure keys.

Changes made -

  • Key rotation is enabled by default for all new keys in the keyring.
  • Key rotation is enabled for existing keys in the keyring if not already enabled. This scenario will executed during upgrade.

Testing -

  • Created an instance with the modified image and newly created kms keys had rotation enabled.
  • Created an image with KMS keys not having rotation enabled. Upgrade the image to a version which uses modified image and rotation got enabled in existing kms keys.
  • Created a MySQL -> Trash pipeline. Inside MySQL source plugin, added macro for secure key value in the password field. Successfully ran the pipeline. Manually rotated the key (the minimum rotation period is 24 hrs). After this, pipeline ran successfully.

@adrikagupta adrikagupta marked this pull request as ready for review June 2, 2025 20:25
@adrikagupta adrikagupta added the build Triggers github actions build label Jun 2, 2025
@adrikagupta adrikagupta force-pushed the key-rotation branch 3 times, most recently from 548d2ec to 457d4a8 Compare June 3, 2025 06:47
Comment thread cdap-common/src/main/resources/cdap-default.xml Outdated

@vsethi09 vsethi09 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
65.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@adrikagupta adrikagupta merged commit 27c9411 into develop Jun 23, 2025
12 of 13 checks passed
@adrikagupta adrikagupta deleted the key-rotation branch June 23, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Triggers github actions build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants