Upgrade Guava library to version 32.0.0-jre in CDAP Watchdog module#16160
Upgrade Guava library to version 32.0.0-jre in CDAP Watchdog module#16160AbhishekKumar9984 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors service lifecycle management by replacing deprecated startAndWait() and stopAndWait() methods with their asynchronous counterparts (startAsync() and stopAsync()), and replaces Guava's Closeables.closeQuietly and Throwables.propagate with standard Java try-catch blocks and explicit exception wrapping. The review feedback highlights that starting and stopping pipelines sequentially in DistributedLogFramework introduces blocking behavior that was previously parallel, potentially causing hangs. Additionally, several of the newly introduced try-catch blocks for closing resources (such as logFileOutputStream, outputStream, dataFileWriter, cl, and classLoaderFolder) lack null checks, which could result in NullPointerExceptions if initialization fails.
2 participants
Updated the Guava dependency version in pom.xml to 32.0.0-jre.
Addressed compatibility issues with the upgraded Guava version.