Upgrade Guava library to version 32.0.0-jre-userInterface pod#16161
Upgrade Guava library to version 32.0.0-jre-userInterface pod#16161AbhishekKumar9984 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors service lifecycle management in StandaloneMain and its corresponding tests by replacing blocking startAndWait() and stopAndWait() calls with asynchronous startAsync().awaitRunning() and stopAsync().awaitTerminated() equivalents. Feedback highlights a critical bug in StandaloneMain where MessagingHttpService is incorrectly started during the shutdown sequence instead of being stopped. Additionally, the import statements in StandaloneMain were reordered out of alphabetical order, which should be reverted.
| @@ -370,7 +370,7 @@ public void shutDown() { | |||
| } | |||
|
|
|||
| // TODO: CDAP-7688, remove next line after the issue is resolved | |||
There was a problem hiding this comment.
I think the start() method call was related to above code comment pointing to CDAP-7688. Can you please once verify if the start() was actually needed as per above comment.
2 participants
Updated the Guava dependency version in pom.xml to 32.0.0-jre.
Ensured compatibility with the upgraded Guava version.