CDAP-21256 : Support preserving client credentials when deleting an OAuth provider#16169
Open
sahusanket wants to merge 1 commit into
Open
CDAP-21256 : Support preserving client credentials when deleting an OAuth provider#16169sahusanket wants to merge 1 commit into
sahusanket wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a preserve_client_credentials option when deleting an OAuth provider, allowing users to preserve existing secrets in the secure store. This is implemented by adding a preserveClientCredentials parameter to OAuthStore.deleteProvider and exposing it as a query parameter in the OAuthHandler DELETE endpoint, along with corresponding unit tests. The review feedback suggests changing the query parameter type in OAuthHandler from boxed Boolean to primitive boolean to avoid a potential NullPointerException during auto-unboxing, which would otherwise result in an incorrect 'Invalid provider' error response.
9ab2fbf to
9936d40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing :
SUCCESS
If the secrets were not present in backend, it will throw an error.