sync: add max_size option#89
Merged
qa-cea merged 5 commits intocea-hpc:masterfrom Apr 22, 2026
Merged
Conversation
rezib
suggested changes
Apr 3, 2026
Collaborator
rezib
left a comment
rezib
left a comment
There was a problem hiding this comment.
I suggest adding a unit test of download_file() utils to cover the new case, with a mocked urlopen() result.
I also suggest 3 easy fixes for new pylint errors introduced.
Pylint also complains about the number of args on many signatures in sync.py. I see that config is not used that much, only for proxy as far as I've seen. Maybe we should consider in the future a small refactoring to provide a SyncOpts object (or similar) to synchronizers with proxy settings and max size, and potentially extensible with other parameters in the future. But not for today.
This patch adds a max_size option for the sync command, to limit the download of RPMs too large. Signed-off-by: VALERI Yoann <yoann.valeri@cea.fr>
Signed-off-by: VALERI Yoann <yoann.valeri@cea.fr>
Signed-off-by: VALERI Yoann <yoann.valeri@cea.fr>
qa-cea
approved these changes
Apr 20, 2026
Signed-off-by: VALERI Yoann <yoann.valeri@cea.fr>
valeriyoann
force-pushed
the
sync_max_size
branch
from
f04ba4f to
3e1b1d5
Compare
rezib
suggested changes
Apr 21, 2026
valeriyoann
force-pushed
the
sync_max_size
branch
6 times, most recently
from
b0fdd1c to
2cc78bd
Compare
rezib
approved these changes
Apr 21, 2026
qa-cea
requested changes
Apr 21, 2026
Signed-off-by: VALERI Yoann <yoann.valeri@cea.fr>
valeriyoann
force-pushed
the
sync_max_size
branch
from
2cc78bd to
cd6344f
Compare
rezib
approved these changes
Apr 22, 2026
qa-cea
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "max_size" option to the sync command, to prevent the download of large files.