Fixes controller disposal logic - #299
Merged
Merged
Conversation
Ensures that the internal `TextEditingController` is only disposed of when it's not provided externally. This prevents errors when the user provides their own controller. Adds tests to verify the correct disposal behavior.
Contributor
|
Thank you very much @xvrh for this PR. I was about to open a new PR to solve this problem, but you already did it 👏 |
Owner
|
Thanks ! |
This was referenced Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #298 introduced a bug when we provide a PhoneController. The widget should only dispose the controller if it was created internally.
cc @kosratdev
Checklist