fix(tests): correct assertion in excluded hours test#858
Merged
auvipy merged 1 commit intocelery:mainfrom Mar 22, 2025
Merged
Conversation
The test_get_excluded_hours_for_crontab_tasks method had assertions for excluded hours that could fail depending on the test execution time. We can only guarantee what hours are not returned by test_get_excluded_hours_for_crontab_tasks and have amended the test to do so.
Author
|
When the test is executed on the 2nd or 6th hour, the assertions checking I have removed these assertions and have added one to verify that "4" and "04" is not in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
==========================================
+ Coverage 87.42% 87.73% +0.31%
==========================================
Files 32 32
Lines 954 954
Branches 76 76
==========================================
+ Hits 834 837 +3
+ Misses 102 100 -2
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alirafiei75
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_get_excluded_hours_for_crontab_tasksmethod had assertions for excluded hours that could fail depending on the test execution time. We can only guarantee what hours are not returned bytest_get_excluded_hours_for_crontab_tasksand have amended the test to do so.