feat: posthog #472
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { scrubAddressesFromUrl, scrubEventUrlProperties } from './posthog'; | ||
|
|
||
| const ADDR = '0xAbCdEf1234567890abcdef1234567890AbCdEf12'; | ||
| const ADDR2 = '0x1111111111111111111111111111111111111111'; | ||
|
|
||
| describe('scrubAddressesFromUrl', () => { | ||
| it('replaces a single address in a path', () => { | ||
| expect(scrubAddressesFromUrl(`/validators/${ADDR}`)).toBe('/validators/[address]'); | ||
| }); | ||
|
|
||
| it('replaces multiple addresses', () => { | ||
| expect(scrubAddressesFromUrl(`/from/${ADDR}/to/${ADDR2}`)).toBe('/from/[address]/to/[address]'); | ||
| }); | ||
|
|
||
| it('is case-insensitive', () => { | ||
| expect(scrubAddressesFromUrl(`/delegate/${ADDR.toLowerCase()}`)).toBe('/delegate/[address]'); | ||
| }); | ||
|
|
||
| it('leaves strings without addresses unchanged', () => { | ||
| expect(scrubAddressesFromUrl('/governance/proposals')).toBe('/governance/proposals'); | ||
| }); | ||
|
|
||
| it('does not match a hex string shorter than 40 chars', () => { | ||
| const short = '0x1234abcd'; | ||
| expect(scrubAddressesFromUrl(`/foo/${short}`)).toBe(`/foo/${short}`); | ||
| }); | ||
|
|
||
| it('handles a full URL', () => { | ||
| expect(scrubAddressesFromUrl(`https://example.com/validators/${ADDR}?ref=home`)).toBe( | ||
| `https://example.com/validators/[address]?ref=home`, | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('scrubEventUrlProperties', () => { | ||
| it('scrubs $current_url', () => { | ||
| const props: Record<string, unknown> = { $current_url: `/validators/${ADDR}` }; | ||
| scrubEventUrlProperties(props); | ||
| expect(props['$current_url']).toBe('/validators/[address]'); | ||
| }); | ||
|
|
||
| it('scrubs $pathname', () => { | ||
| const props: Record<string, unknown> = { $pathname: `/delegate/${ADDR}` }; | ||
| scrubEventUrlProperties(props); | ||
| expect(props['$pathname']).toBe('/delegate/[address]'); | ||
| }); | ||
|
|
||
| it('scrubs $referrer and $initial_referrer', () => { | ||
| const props: Record<string, unknown> = { | ||
| $referrer: `https://example.com/validators/${ADDR}`, | ||
| $initial_referrer: `https://example.com/delegate/${ADDR2}`, | ||
| }; | ||
| scrubEventUrlProperties(props); | ||
| expect(props['$referrer']).toBe('https://example.com/validators/[address]'); | ||
| expect(props['$initial_referrer']).toBe('https://example.com/delegate/[address]'); | ||
| }); | ||
|
|
||
| it('ignores non-string property values', () => { | ||
| const props: Record<string, unknown> = { $current_url: 42 }; | ||
| scrubEventUrlProperties(props); | ||
| expect(props['$current_url']).toBe(42); | ||
| }); | ||
|
|
||
| it('leaves unrelated properties untouched', () => { | ||
| const props: Record<string, unknown> = { | ||
| $current_url: '/governance', | ||
| walletType: 'MetaMask', | ||
| }; | ||
| scrubEventUrlProperties(props); | ||
| expect(props['$current_url']).toBe('/governance'); | ||
| expect(props['walletType']).toBe('MetaMask'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| const EVM_ADDRESS_IN_PATH_RE = /0x[a-fA-F0-9]{40}/gi; | ||
| const REPLACEMENT = '[address]'; | ||
|
|
||
| const SCRUBBED_URL_PROPS = ['$current_url', '$pathname', '$referrer', '$initial_referrer'] as const; | ||
|
|
||
| export function scrubAddressesFromUrl(url: string): string { | ||
| return url.replace(EVM_ADDRESS_IN_PATH_RE, REPLACEMENT); | ||
| } | ||
|
|
||
| export function scrubEventUrlProperties(properties: Record<string, unknown>): void { | ||
| for (const prop of SCRUBBED_URL_PROPS) { | ||
| const value = properties[prop]; | ||
| if (typeof value === 'string') { | ||
| properties[prop] = scrubAddressesFromUrl(value); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
BRIDGE_COUNTS_SOURCEis set toposthog, any transient PostHog failure (rate limit, bad key, network issue) currently drops into the sharedcatchpath and returns an empty list, which makes bridge rankings collapse to all-zero even though the app is still writing analytics events to the local database. This introduces an avoidable production reliability regression for the bridge page; in the PostHog path, failures should fall back togetBridgeClickedCountsFromDb()instead of returning[].Useful? React with 👍 / 👎.