security: Demote threshold_keygen from extern "C" to test helper#172
Merged
Conversation
threshold_keygen took `seed: &[u8]` across an `extern "C"` boundary. A Rust fat pointer has no defined C ABI; any C caller declaring it with `const uint8_t*` would misread the slice length and trigger out-of-bounds reads. cbindgen silently omitted it from threshold.h for this reason, so no legitimate C caller ever existed — the only caller was the internal Rust unit test, and the doc comment already warned that central keygen is for local testing only. Rather than repair the ABI of a function that has no C consumer, demote threshold_keygen and its Keys struct to a plain Rust `#[cfg(test)]` helper. Delete the now-orphaned accessors (share_ptr, num_shares, polynomial_ptr, threshold_public_key_ptr) and destroy_keys, and prune the matching stale declarations from cross/threshold.h. WASM threshold_keygen is unaffected — wasm-bindgen marshals slices correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
threshold_keygen took
seed: &[u8]across anextern "C"boundary. A Rust fat pointer has no defined C ABI; any C caller declaring it withconst uint8_t*would misread the slice length and trigger out-of-bounds reads. cbindgen silently omitted it from threshold.h for this reason, so no legitimate C caller ever existed — the only caller was the internal Rust unit test, and the doc comment already warned that central keygen is for local testing only.Rather than repair the ABI of a function that has no C consumer, demote threshold_keygen and its Keys struct to a plain Rust
#[cfg(test)]helper. Delete the now-orphaned accessors (share_ptr, num_shares, polynomial_ptr, threshold_public_key_ptr) and destroy_keys, and prune the matching stale declarations from cross/threshold.h. WASM threshold_keygen is unaffected — wasm-bindgen marshals slices correctly.