Upgrade jni crate from 0.21.1 to 0.22.4#180
Merged
Merged
Conversation
Rewrite the bridge for the new EnvUnowned/with_env API. The closure now runs under catch_unwind and malformed keys or signatures return false instead of panicking across the FFI boundary (audit fix #1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrades the
jnicrate to 0.22.4 and rewrites the JNI bridge for its redesigned API: native methods now receiveEnvUnownedand access JNI throughwith_env, which runs the body undercatch_unwind.Behavior changes
RuntimeExceptionwith afalsereturn.falseinstead of panicking.Verification
cargo check/clippyclean with--features jvm--features=jni) exportsJava_org_celo_BlindThresholdBls_verify(checked withnm)