fix syntax of conditional assembly directives for aarch64#1630
Closed
qurious-pixel wants to merge 6 commits into
Closed
fix syntax of conditional assembly directives for aarch64#1630qurious-pixel wants to merge 6 commits into
qurious-pixel wants to merge 6 commits into
Conversation
SSimco
reviewed
Jul 4, 2025
| "decoder/arm/ih264d_function_selector.c" | ||
| ) | ||
| target_compile_options(ih264d PRIVATE -DARMV8) | ||
| target_compile_options(ih264d PRIVATE -DARMV8 $<$<COMPILE_LANGUAGE:ASM,Clang>:-Wno-unused-command-line-argument>) |
Collaborator
There was a problem hiding this comment.
I think the issue on aarch64 Linux is that clang doesn't run the C preprocessor on the assembly files.
According to https://developer.arm.com/documentation/100066/0611/assembling-assembly-code/preprocessing-assembly-code you could either replace the assembly code source file suffix from .s to .S or use the -x assembler-with-cpp option. Also, revert the assembly files back to use the #ifdef preprocessor directive.
Suggested change
| target_compile_options(ih264d PRIVATE -DARMV8 $<$<COMPILE_LANGUAGE:ASM,Clang>:-Wno-unused-command-line-argument>) | |
| target_compile_options(ih264d PRIVATE -DARMV8 $<$<COMPILE_LANGUAGE:ASM,Clang>:-Wno-unused-command-line-argument>) | |
| if(NOT MSVC) | |
| set(CMAKE_ASM_FLAGS "${CFLAGS} -x assembler-with-cpp") | |
| endif() |
Contributor
Author
There was a problem hiding this comment.
Yes, this is the right way. closing this PR in favor of @SSimco 's suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1618