Add multiple account detection and implement GetMiiImageEx#1893
Add multiple account detection and implement GetMiiImageEx#1893SirHrVedel wants to merge 12 commits into
Conversation
|
Can you factor out the |
|
I'm totally fine with removing the common.dat code. The point in implementing it was to sort accounts similar to how a real Wii U does it, so it was mainly there for accuracy reasons. I do now realize my implementation of it is a bit rough. |
|
The build check might need to be rerun. GitHub was experiencing workflow issues when they initially ran causing the cmake error. They should be mitigated now (according to the GitHub status site). Other than that the PR should be good for further review. |
|
Im going to need to move the GetMiiImage code to iosu so this PR is not going to be ready for a little while yet. I also just stubbed IsPasswordCacheEnabled, as my implementation wasn't accurate. Stubbing it does essentially the same. |
|
The PR looks good to me. Can you outline which parts were done by Claude exactly? There is a concern that AI might hallucinate parameters for e.g. GetMiiImageEx in a way that is good enough for most games, but not actually fully correct. HLE functions should be verified by a human. |
|
GetMiiImage is very much made by Claude. I only made a very few adjustments to it like making the code more readable. The signature looks correct to me, I verified it using ghidra and it looked good to me. I have made sure to read the code thoroughly and verified it to the best of my abilities. For better accuracy i had Claude disassemble the rpl and fw.img it self and heavily prompted it if I found something out of the ordinary, or with lacking evidence to its claims, just so I was more confident that it was implementing the functions correctly. |
|
It's probably fine, but subtle mistakes in HLE implementation can be incredibly hard to track down later. So I will at some point double check the implementation by hand just to be sure. Unrelated to whether this was made with AI or not, with anything that touches account behavior there is always a (small) chance that it will cause save breakage. So I generally rather merge these kind of changes at the beginning of a release cycle since then there is enough time that someone would notice if there are unexpected side effects. So the plan is to keep this open until 2.7 releases and then after that I will merge it. From a technical standpoint the PR looks ok in the current state and you don't need to further tweak it. |
This reworks the implementation of the account detection system in the iosu that exposes accounts to the emulated os. It allows titles and the Wii U system software to detect other users present in the MLC.
Completely reworked the commented iosu-act multiple account detection implementation so it sorts them based on their persistantId.
Get and use the correct slot number for the active account
Implement GetMiiImageEx so Mii images are no longer blank or use a placeholder image in the Wii U's system software, if ofc the files are present in the accounts files.
Aditionally
Got some coding help from Claude making this.
Closes: #793
Images: