You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Typically, the length parameter passed to H264DECGetImageSize points to several bytes after the end of the SPS NAL unit. These extra bytes are passed into h264Parser_ParseSPS, which eventually returns false when readTrailingRBSPBits is called within parseNAL_seq_parameter_set_rbsp. This behavior causes H264DECGetImageSize to consistently fail to obtain the correct width and height values.
Considering that h264Parser_ParseSPS, parseNAL_seq_parameter_set_rbsp, and readTrailingRBSPBits are very fundamental decoder functions, much existing code might rely on their current behavior. Therefore, I only made modifications within H264DECGetImageSize. By simply truncating the extra data after the first found SPS NAL unit, h264Parser_ParseSPS can now return the correct width and height parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.