fix(gorgone-mbi): wrong order execution for events calculation by garnier-quentin · Pull Request #1692 · centreon/centreon-collect

garnier-quentin · 2024-09-12T13:11:22Z

Description

There is a race condition with rebuild. Some tables are filled before the the DROP/CREATE.

Type of change

Patch fixing an issue (non-breaking change)
New functionality (non-breaking change)
Breaking change (patch or feature) that might cause side effects breaking part of the Software
Updating documentation (missing information, typo...)

Target serie

How this pull request can be tested ?

It's a race condition so it's kind of difficult to reproduce. You can test the rebuild is still working.

Checklist

I have followed the coding style guidelines provided by Centreon
I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
I have commented my code, especially hard-to-understand areas of the PR.
I have made corresponding changes to the documentation.
I have rebased my development branch on the base branch (master, maintenance).

* Add pb_neb_lib dependencies to centenginestats * Add pb_bam_lib dependencies to engine_legacy_conf REFS: MON-147186

centreon#1680) * fix(common/engine_conf): multiple inheritence broken because of a missing flag enabled * fix(common/log_v2): segfault in centengine fixed * fix(engine/config/applier): bad use of std::equal * fix(tests/engine): new test * fix(broker/neb): cbmod was linked with not needed libraries * fix(broker/lua): a memory leak introduced with the new openssl md5 fixed * fix(tests/engine): a new test to validate the good behavior of inheritance * enh(cmake): new option LEGACY_ENGINE to compile the legacy engine instead of the new one * fix(gh/alma8): maxscale repo is disabled on alma8 * fix(cmake): issues with dependencies * enh(gha): new possibility to save packages as artifacts REFS: MON-147499

coderabbitai · 2024-09-12T13:11:38Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

y-kacher · 2024-09-23T14:24:06Z

Hi @garnier-quentin,

Indeed, thanks for the performance enhancements, it avoids multiple requests to the db. It would be perfect if you could add a message like below :

[WARNING] The service template with id = 2701 inherits the template ID = 2702 more than once, please check relations of the template with ID = 2701!

Or before exiting the function (to avoid too much log writing):

[WARNING] The service template loop detected !

kduret · 2024-12-13T10:36:42Z

I moved it as draft until conflicts are resolved

garnier-quentin · 2025-03-25T14:37:40Z

I moved it as draft until conflicts are resolved

Sorry for the delay. conflicts are solved

Tpo76 · 2026-04-14T23:54:55Z

🤖 This is an automatic comment generated by an internal tool.

Complexity Classification: Standard

Justification: Automatic classification failed; defaulting to standard.

Metric	Value
WIP Points	2
SLA Track	Standard SLA (2 work days)
First review SLA	1 work day

A maintainer can override this classification at any time.

Tpo76 · 2026-04-15T01:23:08Z

🤖 This is an automatic comment generated by an internal tool.

This PR does not appear to be linked to a Jira ticket.

PRs without a linked Jira ticket will not be prioritized for review. To get this PR reviewed, please:

Create or find the corresponding Jira ticket
Add the ticket key (e.g., MON-12345) to the PR title or description

Once linked, this PR will be automatically classified and tracked.

sechkem and others added 8 commits September 5, 2024 09:13

enh(clib):Remove basic/interruption_error (centreon#1650)

cb70ed3

* Add pb_neb_lib dependencies to centenginestats * Add pb_bam_lib dependencies to engine_legacy_conf REFS: MON-147186

no engine_otl_endpoint parameter in telegraf config (centreon#1676)

d883265

fix(packaging): add dependency to perl(lib) (centreon#1681)

45a726c

fix(gorgone-mbi): wrong order execution for events calculation

adc5000

fix(gorgone-mbi): wrong order execution for events calculation

9d2a775

fix(gorgone-mbi): wrong order execution for events calculation

6ad8fe6

fix(gorgone-mbi): wrong order execution for events calculation

4830554

garnier-quentin requested a review from a team as a code owner September 12, 2024 13:11

garnier-quentin requested a review from lucie-tirand September 12, 2024 13:11

garnier-quentin added 4 commits September 17, 2024 12:15

wip

f75de37

wip

c30b260

wip

2f95996

wip

ce5527f

garnier-quentin mentioned this pull request Sep 19, 2024

Avoid template loops (causing infinite loop) while calculating dimension #1516

Closed

10 tasks

bouda1 force-pushed the develop branch from 691b8d2 to 9b5b1c7 Compare September 25, 2024 08:14

bouda1 requested review from a team as code owners September 25, 2024 08:14

bouda1 requested review from Evan-Adam, ddes, jean-christophe81 and mushroomempires September 25, 2024 08:14

bouda1 force-pushed the develop branch from d763134 to ce58da6 Compare October 3, 2024 16:07

kduret marked this pull request as draft December 13, 2024 10:36

tuntoja previously approved these changes Jan 7, 2025

View reviewed changes

wip

666249d

github-actions Bot added the external label Mar 25, 2025

garnier-quentin added 12 commits March 25, 2025 10:17

wip

37bb5e1

wip

6931f1b

wip

8eec80b

wip

f0b76c8

wip

d522f2a

wip

d08376d

wip

fe65fc3

wip

1386842

wip

6a11491

wip

0336d85

wip

ee1c2b4

Merge branch 'develop' into mbi-wrong-order-execution

4f9daca

garnier-quentin dismissed tuntoja’s stale review via 4f9daca April 27, 2026 10:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(gorgone-mbi): wrong order execution for events calculation#1692

fix(gorgone-mbi): wrong order execution for events calculation#1692
garnier-quentin wants to merge 25 commits into
centreon:developfrom
garnier-quentin:mbi-wrong-order-execution

garnier-quentin commented Sep 12, 2024

Uh oh!

coderabbitai Bot commented Sep 12, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

y-kacher commented Sep 23, 2024 •

edited

Loading

Uh oh!

kduret commented Dec 13, 2024

Uh oh!

garnier-quentin commented Mar 25, 2025

Uh oh!

Tpo76 commented Apr 14, 2026

Uh oh!

Tpo76 commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

garnier-quentin commented Sep 12, 2024

Description

Type of change

Target serie

How this pull request can be tested ?

Checklist

Uh oh!

coderabbitai Bot commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

y-kacher commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kduret commented Dec 13, 2024

Uh oh!

garnier-quentin commented Mar 25, 2025

Uh oh!

Tpo76 commented Apr 14, 2026

Complexity Classification: Standard

Uh oh!

Tpo76 commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

coderabbitai Bot commented Sep 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

y-kacher commented Sep 23, 2024 •

edited

Loading