chore(packaging): refactor dep graph — break broker/engine cycles and verticalize gorgone#3437
Draft
Tpo76 wants to merge 1 commit into
Draft
Conversation
- centreon-broker: remove deps on centreon-clib and centreon-broker-core (cycle) - centreon-engine-daemon: remove deps on centreon-engine and centreon-engine-opentelemetry (cycle) - centreon-common: remove deps on centreon-broker and centreon-engine-daemon (layer inversion) - centreon-gorgone: add dep on centreon-gorgone-centreon-config (daemon pulls its config) - centreon-gorgone-centreon-config: remove dep on centreon-gorgone (inversion resolved) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tpo76
changed the title
Robot Results
Failed Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
centreon-broker: remove circular deps oncentreon-clibandcentreon-broker-core—brokerships dirs/user,broker-coreships.solibs; one direction (core → broker) is sufficientcentreon-engine-daemon: remove circular deps oncentreon-engineandcentreon-engine-opentelemetry—engineis a meta-wrapper abovedaemon;opentelemetryis an optional plugin declared upstream bycentreon-pollercentreon-common: remove layer-inversion deps oncentreon-brokerandcentreon-engine-daemon—commonis a real base layer (Linux user + dirs); collect stack deps are re-declared by packages that actually need themcentreon-gorgone: add dep oncentreon-gorgone-centreon-config— the daemon pulls its own Centreon configcentreon-gorgone-centreon-config: remove dep oncentreon-gorgone— resolves the config ↔ daemon cycle; config now only depends oncentreon-commonPart of MON-196795 — 3-repo PR series (centreon-collect / centreon / centreon-modules).
Architecture: centreon-package-deps-architecture.md
Test plan
dnf install centreon-poller→ verify full collect stack is present,cbdis NOT installeddnf install centreon-web→ verify no collect component or broker daemon is pulleddnf install centreon(umbrella) → verify non-regression vs current install,cbdpresent on central.github/workflows/for jobs depending oncentreon-commonpulling the collect stack🤖 Generated with Claude Code