Skip to content

fix(gorgone): correctly delete poller for pull communication type#3464

Open
Evan-Adam wants to merge 2 commits into
developfrom
MON-197880-gorgone-fix-uid-identification
Open

fix(gorgone): correctly delete poller for pull communication type#3464
Evan-Adam wants to merge 2 commits into
developfrom
MON-197880-gorgone-fix-uid-identification

Conversation

@Evan-Adam

Copy link
Copy Markdown
Contributor

Refs:MON-197880

Description

When poller exist in database and are deleted but still try to connect with pull communication type (don't happend pullwss mode) there was multiples perl error in the logs.
Now a clear log indicate to the user that the poller do not exist and no perl error are present. automated tests had been modified to test that, even if a real test would wait more than one minute, as poller reconnection happend only every minutes.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 23.10.x
  • 24.04.x
  • 24.10.x
  • 25.10.x
  • master

How this pull request can be tested ?

See automated test, you should create a central with a poller in pull communication mode, and delete the row in DB, force central to read database again, and wait for error in the central log.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@Evan-Adam Evan-Adam requested review from a team as code owners June 16, 2026 16:38
@Evan-Adam Evan-Adam requested review from jean-christophe81 and sdepassio and removed request for a team June 16, 2026 16:38
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 055c3bf1-5365-46b7-a687-1d24b3d0b3a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MON-197880-gorgone-fix-uid-identification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant