new mode "output-banks" for plugin APC-ATS

[rmorandell-pgum]

Community contributors

Description

APC-ATS has output banks

The new mode checks the total/overall status and perf data and the single bank data.

Type of change

• Patch fixing an issue (non-breaking change)
• New functionality (non-breaking change)
• Functionality enhancement or optimization (non-breaking change)
• Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

powernet441.mib.txt

atsOutputBankTable -> atsOutputBankEntry

Here is the walk:

ats.snmpwalk.txt

Checklist

• I have followed the coding style guidelines provided by Centreon
• I have commented my code, especially hard-to-understand areas of the PR.
• I have rebased my development branch on the base branch (develop).
• I have provide data or shown output displaying the result of this code in the plugin area concerned.

[aikido-pr-checks]

The check uses keys %{$self->{bank}} even when $self->{bank} may be undefined, which can crash instead of reaching the "No banks matching" path.

Suggested change

	if (!defined($self->{global}) && scalar(keys %{$self->{bank}}) <= 0) {
	if (!defined($self->{global}) && (!defined($self->{bank}) || scalar(keys %{$self->{bank}}) <= 0)) {

Details

✨ AI Reasoning
​The final emptiness check assumes two containers may both be empty, but one of them is not initialized before being dereferenced. If no per-bank entry is stored during selection and the overall entry is also missing, evaluating the hash key count on an undefined reference can fail before the intended "No banks matching" message is emitted.

_{Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info}