CFE-3988: Fixed insert_lines ignoring include_end_delimiter when locating the region (3.27) - #6291
Open
nickanderson wants to merge 1 commit into
Open
CFE-3988: Fixed insert_lines ignoring include_end_delimiter when locating the region (3.27)#6291nickanderson wants to merge 1 commit into
nickanderson wants to merge 1 commit into
Conversation
…egion The insertion path treats the selected region as the half-open range [begin_ptr, end_ptr), so the end delimiter was never inside it. Inserting after the last line of a region built with include_end_delimiter => "true" landed above the end delimiter instead of below it. Insertion now moves the bound the way DeletePromisedLinesMatching() already does. That attribute previously had no effect at all on insert_lines, so the default of inserting before an excluded end delimiter is unchanged. Acceptance test 31_tickets/CFE-3988/2 covers that default and 31_tickets/CFE-3988/1 is no longer a soft failure. Ticket: CFE-3988 Changelog: Title Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 7313aa2)
Member
Author
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14507/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14507/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserting after the last line of a region built with
include_end_delimiter => "true"landed above the delimiter instead of below it, because the insertion path treats the region as the half-open range[begin_ptr, end_ptr).Backport of #6265.
Ticket: CFE-3988