OfficialAPI: add river race and river race log endpoints#41
Open
gogaz wants to merge 1 commit intocgrok:masterfrom
Open
OfficialAPI: add river race and river race log endpoints#41gogaz wants to merge 1 commit intocgrok:masterfrom
gogaz wants to merge 1 commit intocgrok:masterfrom
Conversation
gogaz
force-pushed
the
patch-2
branch
7 times, most recently
from
16217fe to
9eea1d4
Compare
gogaz
changed the title
Contributor
Author
|
@fourjr any chance to have this reviewed any time soon? |
|
How is this going @fourjr ? I'm interested in using it in my project. |
Contributor
|
Hey, I've been busy over the past week. Will review and push to PyPi by end of next week. |
Contributor
|
Hey, sorry for the late reply, why isn't the get_clan_war method removed? From the api documentation, /currentwar is no longer in use. |
Contributor
Author
|
@fourjr good catch, I hadn't tested it! |
|
What status with this branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Description
Update war logs URL to match the latest version of Clash Royale
Given that the endpoint data format for river races slightly differs from previous clan wars, I advocate for new methods over modificating
get_clan_war*methods.Type of PR
Checklist
If necessary, add to the documentation files