Add placement tolerations check to ocp-best-practices policy set - #2
Merged
Merged
Conversation
Ports open-cluster-management-io/policy-collection#556: hub-targeted policy-placement-tolerations, openshift-best-practices-hub policy set, and explicit policySets overrides for existing spoke policies. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports open-cluster-management-io/policy-collection#556 into the consolidated
ocp-best-practicespolicy set:openshift-best-practices-hubpolicy set withinput/hub-placement.yamlpolicy-placement-tolerations(critical, inform) to ensure all hub Placements includeunreachableandunavailabletolerationspolicySets: [openshift-best-practices]on existing spoke policies so they are not pulled into the hub set viapolicyDefaultsDifferences from upstream PR
placement-openshift-best-practices-hub(upstream PR copiesplacement-openshift-plus-hubfrom openshift-plus)policies/policy-sets/community/ocp-best-practices/(consolidation layout vs upstreampolicygenerator/...)Relationship to existing consolidation policy
policies/acm-configs/ensure-placement-toleration/already enforces placement tolerations fleet-wide (enforce,env-bound-hub-placement). This change adds the same check as an inform policy inside the ocp-best-practices community policy set bundle, matching upstream intent.Test plan
./build/validate-policies.shpassesocp-best-practiceskustomize build generates 18 valid resources (was 15)policy-placement-tolerationsreports on Placements missing tolerationsopenshift-best-practicesonly (not hub set)Made with Cursor