Add documentation for using chai-jquery with an AMD like require.js#68
Open
jvennix-rmn wants to merge 2 commits intochaijs:masterfrom
Open
Add documentation for using chai-jquery with an AMD like require.js#68jvennix-rmn wants to merge 2 commits intochaijs:masterfrom
jvennix-rmn wants to merge 2 commits intochaijs:masterfrom
Conversation
fearphage
reviewed
Dec 24, 2016
| ```js | ||
| require([ | ||
| 'chai-jquery' | ||
| ], function(chaiJquery) { |
There was a problem hiding this comment.
Shouldn't you require chai as well? You don't want to rely on a global instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me a minute to look through the source to see how to do this.