Add MPCQ Network and assets#1444
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b913e582a9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "currencies": [{ | ||
| "coinDenom": "MPCQ", | ||
| "coinDecimals": 18 | ||
| }] |
There was a problem hiding this comment.
This config does not define feeCurrencies, but repository validation and tooling assume the field exists and iterate it unguarded (for example checkCurrencies in src/validate.ts and image checks in src/index.ts), so processing this chain will throw at runtime instead of loading metadata. Please add feeCurrencies (normally including the native gas token) and keep it consistent with currencies.
Useful? React with 👍 / 👎.
| "coinDenom": "MPCQ", | ||
| "coinDecimals": 18 |
There was a problem hiding this comment.
The only currency object is missing coinMinimalDenom, but downstream validation/normalization treats this field as required (for example checkCurrencies uses currency.coinMinimalDenom to construct DenomHelper in src/validate.ts), so this chain config cannot be validated or reliably consumed by clients. Add a valid minimal denom string and reuse it consistently across related currency fields.
Useful? React with 👍 / 👎.
1 participant
Changes
Checklist
yarn validate <your-config-file>locally, and it passed without any errors.