Avoid external cache for QEMU#2018
Closed
egibs wants to merge 1 commit into
Closed
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
commented
May 30, 2025
| clog.FromContext(ctx).Debugf("qemu: additional mountpoint %s into /mount/%s", v.Destination, v.Destination) | ||
| setupMountCommand = setupMountCommand + "&& mkdir -p /mount/" + v.Destination + | ||
| " && mount -t 9p " + v.Destination + " /mount/" + v.Destination | ||
| " && mount -t 9p " + v.Destination + " /mount/" + strings.TrimPrefix(v.Destination, "/") |
Member
Author
There was a problem hiding this comment.
This was resulting in /mount//var/cache/melange.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
/var/cache/melangewithin QEMU over9p(at least on macOS?) has sizable performance implications. For instance, I spent 20 minutes downloading Go packages and still did not manage to move onto a build.For QEMU, we can use a local directory in
/home/buildto avoid the performance hit unless there's a better way to do this. This also improves the isolation story since we aren't sharing a cache between builds.Edit:
cadvisorbuilds in ~90 seconds in CI with this code and it previously took ~5 minutes.