Skip to content

Preserve unchanged secret env values#28

Merged
eetoc merged 1 commit into
mainfrom
codex/fix-secret-env-preserve
Jun 18, 2026
Merged

Preserve unchanged secret env values#28
eetoc merged 1 commit into
mainfrom
codex/fix-secret-env-preserve

Conversation

@eetoc

@eetoc eetoc commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #25 by allowing existing masked global Secret environment variables to be saved without re-entering their values.

Details

  • Treat an empty incoming Secret value as "preserve the existing Secret" only when that Secret already exists in global env storage.
  • Reject new empty Secret values with so empty strings do not become valid Secret payloads.
  • Keep deletion semantics unchanged: removing an env item from the submitted list deletes it.
  • Update the settings page so unknown existing Secrets can be saved, while newly entered empty Secrets are still blocked.
  • Reload global env items after save so preserved Secrets return to the masked/unknown state in the UI.

Validation

  • ok agent-compose/pkg/agentcompose (cached)

check:ui
vite build --config frontend/vite.config.ts

4:42:22 PM [vite-plugin-svelte] no Svelte config found at /private/tmp/agent-compose-fix-secret/frontend - using default configuration.
vite v7.3.2 building client environment for production...
transforming...
✓ 273 modules transformed.
rendering chunks...
computing gzip size...
../dist-ui/index.html 0.37 kB │ gzip: 0.26 kB
../dist-ui/assets/index-DzucqM_C.css 112.91 kB │ gzip: 18.82 kB
../dist-ui/assets/index-420bYWVw.js 703.94 kB │ gzip: 189.13 kB
✓ built in 5.05s

@eetoc eetoc changed the title [codex] Preserve unchanged secret env values Preserve unchanged secret env values Jun 18, 2026
@eetoc eetoc marked this pull request as ready for review June 18, 2026 09:39
@eetoc

eetoc commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author
issue25-01-secret-masked-before-save issue25-02-added-normal-with-secret-unchanged issue25-03-save-success-secret-preserved

@eetoc eetoc merged commit 2ac962b into main Jun 18, 2026
13 checks passed
@eetoc eetoc deleted the codex/fix-secret-env-preserve branch June 18, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 全局环境变量Secret 脱敏与保存逻辑冲突

1 participant