Skip to content

Remove Daily Degen from morning briefing - #24

Merged
chapati23 merged 2 commits into
mainfrom
feature/daily-degen-email-workflow
May 18, 2026
Merged

Remove Daily Degen from morning briefing#24
chapati23 merged 2 commits into
mainfrom
feature/daily-degen-email-workflow

Conversation

@gisk0

@gisk0 gisk0 commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove Daily Degen from the morning briefing source registry.
  • Delete the old Daily Degen source and test coverage from this repo.
  • Clarify that AgentMail usage here is only for OpenSea OTP login now.
  • Keep dependency overrides required by the existing pre-push security hook.

Daily Degen now lives in the OpenClaw/Hetzner workflow outside this repo.

Verification

  • bun run typecheck
  • bun test
  • bun run knip
  • trunk check --fix
  • Pre-push hook: tsc, bun test --coverage, knip

@gisk0
gisk0 force-pushed the feature/daily-degen-email-workflow branch from 5672cfc to eff6dcc Compare May 18, 2026 09:59
@gisk0 gisk0 changed the title Add Daily Degen email workflow Remove Daily Degen from morning briefing May 18, 2026
@gisk0
gisk0 force-pushed the feature/daily-degen-email-workflow branch from eff6dcc to fba504b Compare May 18, 2026 10:02
@chapati23

Copy link
Copy Markdown
Owner

@claude review

@claude

claude Bot commented May 18, 2026

Copy link
Copy Markdown

Claude finished @chapati23's task in 1m 20s —— View job


PR Review

  • Gather context
  • Read changed files and diff
  • Review code
  • Post findings

Overall: clean, complete removal. LGTM.

The PR consistently strips Daily Degen from all layers — source implementation, test coverage, registry wiring, and documentation — with no orphaned references left behind.

What looks good

Complete deletion coverage — both src/sources/daily-degen.ts and tests/daily-degen.test.ts are deleted, and src/sources/index.ts has the imports and registry entries removed from both getRealSources() and getMockSources(). Nothing was missed.

cheerio dep is still neededetf-flows.ts and congress-trades.ts both import cheerio, so dropping it from package.json would have been wrong. It's correctly left in place.

AGENTMAIL_API_KEY correctly retained — the description in AGENTS.md is updated to clarify it's for OpenSea OTP login only, which is accurate.

Terraform example improved — the comment in terraform/terraform.tfvars.example now explicitly lists agentmail_api_key and agentmail_email_address as secrets, which previously would have left a fresh deployer wondering where those env vars came from.

Minor observations

basic-ftp major version bump (5 → 6) in overridepackage.json and bun.lock move the transitive override from ^5.3.0^6.0.1. Since this is an override for a transitive dep (not a direct import), the risk of a breaking API change is low — but it's a major version jump and worth a quick smoke-test on the pre-push hook if you haven't already. Looks intentional given the prior f6913d7 security-fix commit.

ip-address added as new override — bumped from 10.1.010.2.0 via a new override entry. This was presumably flagged by the osv-scanner pre-push hook. Good catch.

HANDOVER.md added to .gitignore — presumably a working notes file you don't want tracked. Totally fine, just an implicit acknowledgement that this file may exist locally.

No issues to fix. Safe to merge.

@claude

claude Bot commented May 18, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@chapati23
chapati23 merged commit 76369dd into main May 18, 2026
3 checks passed
@chapati23
chapati23 deleted the feature/daily-degen-email-workflow branch May 18, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants