feat: split App Store rankings into Finance and Total subsections - #3
Merged
Conversation
- Finance subsection: ranked apps only, no '#Finance' label (implied by section header) - Total subsection: overall top-100 apps only, hidden if none are ranked - Add overall trend tracking (daily/weekly/monthly) for Total section items - Update types to allow DataSource.fetch to return BriefingSection[] - Orchestrator flattens multi-section results transparently - All 394 tests passing
Add sentimentPrefix flag to BriefingItem; App Store Finance and Total items now render as '• 🔴 Coinbase: #33 (...)' matching ETF style.
chapati23
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Splits the single 'App Store Rankings' section into two cleaner subsections:
📱 App Store · Finance
#Financelabel from each line (implied by section header)📱 App Store · Total (conditional)
overalllabel from each line (implied by section header)Why
Changes
types.ts: DataSource.fetch can now returnBriefingSection | BriefingSection[]orchestrator.ts: flattens multi-section results transparentlyappstore-rankings.ts: split build logic, newformatFinancePositionText/formatOverallPositionText