Skip to content

Fix type mismatch warning #27909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkmgit wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix type mismatch warning #27909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3234995
Fix type mismatch warning
bkmgit Oct 14, 2025
0205b97
Use correct variable
bkmgit Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions runtime/src/comm/ofi/comm-ofi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7997,7 +7997,7 @@ int isAtomicValid(enum fi_datatype ofiType) {
static int validByType[FI_DATATYPE_LAST];

if (!inited) {
for (enum fi_datatype t = 0; t < FI_DATATYPE_LAST; t++) {
for (int t = 0; t < static_cast<int>(FI_DATATYPE_LAST); t++) {
validByType[t] = computeAtomicValid(t);
}
inited = true;
Expand All @@ -8013,7 +8013,7 @@ int isAtomicValid(enum fi_datatype ofiType) {
struct fid_ep* ep = tciTab[0].txCtx; // assume same answer for all
// endpoints

for (enum fi_datatype t = 0; t < FI_DATATYPE_LAST; t++) {
for (int t = 0; t < static_cast<int>(FI_DATATYPE_LAST); t++) {
offset = 0;
offset += snprintf(buf + offset, sizeof(buf) - offset, "%s: ",
fi_tostr(&t, FI_TYPE_ATOMIC_TYPE));
Expand Down Expand Up @@ -8042,9 +8042,10 @@ int isAtomicValid(enum fi_datatype ofiType) {
}
DBG_PRINTF(DBG_CFG_AMO, "%s", buf);
}
for (enum fi_datatype t = 0; t < FI_DATATYPE_LAST; t++) {
DBG_PRINTF(DBG_CFG_AMO, "%s: %s", fi_tostr(&t, FI_TYPE_ATOMIC_TYPE),
validByType[t] ? "valid" : "invalid");
for (int t = 0; t < static_cast<int>(FI_DATATYPE_LAST); t++) {
fi_datatype fiT = static_cast<fi_datatype>(t);
DBG_PRINTF(DBG_CFG_AMO, "%s: %s", fi_tostr(&fiT, FI_TYPE_ATOMIC_TYPE),
validByType[fiT] ? "valid" : "invalid");
}
}
#endif
Expand Down