Fix runtime type bug with c_ptr.eltType#28291
Open
jabraham17 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where runtime types where not properly removed when compiling code with
--debug.The bug is really that the compiler doesn't know how to codegen types (which it shouldn't) and earlier phases of the compiler don't remove some type calls properly. This makes
--dead-code-eliminationan essential pass to run. However, DCE, can remove important information when debugging. To workaround this, this PR partially re-enables DCE with--debug, keeping enough to make the compiler not crash.Resolves
--debug#28285 work with--debug