Say more about the expected impact of defining record comparisons in modules#28780
Open
bradcray wants to merge 1 commit into
Open
Say more about the expected impact of defining record comparisons in modules#28780bradcray wants to merge 1 commit into
bradcray wants to merge 1 commit into
Conversation
…modules --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
Member
Author
|
@jabraham17 : Is this the sort of description you were hoping for? |
jabraham17
reviewed
May 6, 2026
jabraham17
left a comment
jabraham17
left a comment
Member
There was a problem hiding this comment.
I feel like now its too much and like we are hedging because we are not sure about the change
Instead of hedging, I propose just clearly stating any expected changes
This changes records that only have tertiary definitions of such operators (which is to
say, ones that are defined in a different module than the record
itself). In such cases, these default, module-defined comparison
operators will be available for the record type in scopes where the
tertiary operators are not available.
Comment on lines
+172
to
+175
| operators for a given record type. For most programs, this should | ||
| not result in any behavior change, and we encourage you to reach out | ||
| and let us know if you find otherwise. | ||
|
|
Member
There was a problem hiding this comment.
putting my user hat on, if we expect no behavior changes why is this in the preview edition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.