Skip to content

Refactor legacy pure-function logic#13

Open
charles-turner-bot wants to merge 2 commits into
charles-turner-1:mainfrom
charles-turner-bot:refactor-legacy-pure-functions
Open

Refactor legacy pure-function logic#13
charles-turner-bot wants to merge 2 commits into
charles-turner-1:mainfrom
charles-turner-bot:refactor-legacy-pure-functions

Conversation

@charles-turner-bot

Copy link
Copy Markdown
Contributor

Summary

  • extract a small set of logic-bearing pure helpers from the legacy camelCase path into src/legacy_pure_functions.jl
  • reuse those helpers from partial-cruise and exception-handling code without changing external behaviour
  • add unit tests covering the extracted pure functions and wire them into the package test suite

Testing

  • docker run --rm -v "$PWD":/work -w /work julia:1.11 julia --project=. -e 'using Pkg; Pkg.test()'

Notes

  • this intentionally avoids turning the legacy path into a pile of tiny wrappers; only the chunky testable logic was extracted
  • existing package precompile warnings about duplicate method definitions were observed during test setup but the full suite still passed (65/65)

@codecov-commenter

codecov-commenter commented Apr 29, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##            main      #13       +/-   ##
==========================================
+ Coverage   7.82%   20.09%   +12.27%     
==========================================
  Files         16       17        +1     
  Lines       1023     1030        +7     
==========================================
+ Hits          80      207      +127     
+ Misses       943      823      -120     
Files with missing lines Coverage Δ
src/GLODAP_Section_Gridder.jl 100.00% <ø> (ø)
src/exception_handling.jl 24.24% <100.00%> (+24.24%) ⬆️
src/legacy_pure_functions.jl 100.00% <100.00%> (ø)
src/partial_cruises.jl 14.94% <100.00%> (+14.94%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants