Add fine-grained equality methods for key bindings#916
Open
Kapparina wants to merge 7 commits intocharmbracelet:mainfrom
Open
Add fine-grained equality methods for key bindings#916Kapparina wants to merge 7 commits intocharmbracelet:mainfrom
Kapparina wants to merge 7 commits intocharmbracelet:mainfrom
Conversation
- Implement `Equal` method to check for equality of keys and help text. - Import `slices` package to simplify key comparison logic.
# Conflicts: # go.mod # textarea/textarea.go # textarea/textarea_test.go
- Introduce `EqualKeys`, `EqualHelp`, and `EqualDisabled` methods. - Refactor `Equal` to use the new fine-grained methods. - Add unit tests to verify equality logic.
- Convert package-level comment to block style for better readability. - Reformat function comments for improved line breaks and structure.
- Reformat `UPGRADE_GUIDE_V2.md` for improved readability and consistency. - Update package import paths and migration tables for v2. - Enhance `README.md` with alt text and fix typos.
- Verify equality logic between identical bindings. - Test scenarios with differing enabled states and key sets. - Ensure correct behaviour when comparing distinct bindings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces enhancements to the
keypackage by implementing fine-grained equality methods for key bindings, improving clarity, and providing better comparison functionality.Prerequisites
CONTRIBUTING.md.Changes
Changes include:
EqualKeys,EqualHelp, andEqualDisabledmethods for specific equality checks.Equalmethod to leverage fine-grained equality methods.Notes
This PR is an extension of PR #773, which was missed prior to the v2-to-main merge.