fix(deploy): the gate reads the plan schema this checkout declares - #402
Merged
Conversation
It asserted schema 4. The constant is now 6, moved twice by the architecture-conformance work, so the first categorical deploy witness failed on a number rather than on anything about the deployment. A gate that goes red because the format advanced is a gate people learn to ignore. The expected value now comes from PLAN_SCHEMA in this checkout's source. That is sound precisely because of the revision assertion added alongside it: the gate has already confirmed the live server IS this commit, so the constant here is the constant it was built from. Hardcoding a value the code derives asserts today's number instead of the agreement between the two — the same mistake the cache tests made with the planner's semantics version, one rung earlier. Run from outside a checkout the number cannot be read, so the gate still refuses a document carrying no schema at all but says plainly that the number went unverified, rather than passing as though it had checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first categorical deploy witness failed — on a hardcoded number, not on the deployment.
The gate asserted
plan schema 4.PLAN_SCHEMAis now 6, moved by thearchitecture-conformance work. A gate that goes red because the format advanced is a gate
people learn to ignore.
The expected value now comes from
PLAN_SCHEMAin this checkout's source. That is soundbecause of the revision assertion added in #401: the gate has already confirmed the live
server is this commit, so the constant here is the constant it was built from.
Same mistake the cache tests made with
PLANNER_SEMANTICS_VERSIONone rung earlier —hardcoding a value the code derives asserts today's number rather than the agreement between
the two.
Run from outside a checkout, the number can't be read; the gate still refuses a document
carrying no schema but says the number went unverified rather than passing as though checked.
The witness, now complete
Every link asserted rather than inferred: which code is live, what it judged, how it judged
it, and that the important path still behaves.