test: add unit tests for API utils and skill prerequisites (Phase 2)#106
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
test: add unit tests for API utils and skill prerequisites (Phase 2)#106github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Add coverage for previously untested pure functions: - src/lib/api/validation-utils.test.ts: 20 tests for validateObject and validateRequiredString - src/lib/api/response-utils.test.ts: 13 tests for apiSuccess, validationErrorResponse, serviceUnavailableResponse - src/lib/skills/prerequisites.test.ts: 12 tests for getNextAchievableSkills All 45 new tests pass. Closes #55. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 implementation from the Daily Test Coverage Improver plan. Adds 45 new unit tests across 3 previously untested files.
Coverage improvements
src/lib/api/validation-utils.tsvalidateObject,validateRequiredString— null/undefined/wrong-type inputs, empty/whitespace strings, field name in messagessrc/lib/api/response-utils.tsapiSuccess(200),validationErrorResponse(400),serviceUnavailableResponse(503) — status codes, body shape, meta inclusion/omissionsrc/lib/skills/prerequisites.tsgetNextAchievableSkills— empty profile, prerequisite unlocking, already-intermediate exclusion, duplicate skill deduplication (highest level wins), full-advanced empty result, multi-prerequisite chainsBaseline: 63 test files, 1035 tests
After: 66 test files, 1080 tests (+45)
Test approach
*.test.ts, AAA pattern,it.eachfor table-driven casesresponse-utilstests callNextResponse.jsondirectly and assert on status codes and parsed JSON body shapesCloses
Resolves #55