[perf] Replace static inline styles in RelatedSuggestions with CSS classes#107
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
[perf] Replace static inline styles in RelatedSuggestions with CSS classes#107github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Replace two static inline style objects on Text components in
RelatedSuggestions.tsx with CSS module classes:
- style={{ fontWeight: 600 }} → .suggestionTitle class
- style={{ fontStyle: 'italic', color: 'var(--fgColor-muted)' }} → .suggestionReason class
Static style objects passed to JSX create new object references on every
render, causing extra style recalculation work in the browser. Moving them
to CSS classes allows the browser to cache the computed styles.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Pull request created: #107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces 2 static
style=\{\{}}objects onTextcomponents inRelatedSuggestions.tsxwith CSS module classes.Tier
Tier 2 — Render & API Performance (inline
style=\{\{}}elimination)Baseline
RelatedSuggestions.tsxrendered twoTextcomponents with static inline style objects:Both objects are static (their values never change based on props or state). Static inline style objects create a new object reference on every render, forcing React to diff the style prop even though nothing changed, and the browser to re-evaluate computed styles unnecessarily.
Fix
Added two CSS classes to the
.relatedSuggestion*section inChallengeSandbox.module.css:Updated
RelatedSuggestions.tsxto useclassNameinstead:All 1025 passing tests continue to pass. The 10 pre-existing failures are unrelated (GitHub auth mock issues in
client.test.ts).