[perf] Replace static inline styles in habit-list-section with CSS classes#110
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
[perf] Replace static inline styles in habit-list-section with CSS classes#110github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
…sses
Replace 6 static inline style objects with 4 new CSS classes in
habits.module.css. These create new style objects on every render,
causing unnecessary style recalculations in the browser.
Added classes:
- .actionsStack — marginTop on action buttons Stack
- .sectionHeading — fontSize 1.25rem on section Headings (x3)
- .emptyHeading — fontSize + marginTop on empty-state Heading
- .emptyText — color + marginTop on empty-state Text
The dynamic style={{ width }} is intentionally kept as it depends on
runtime state.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces 6 static
style=\{\{}}objects inhabit-list-section.tsxwith 4 named CSS classes inhabits.module.css. Each inline style object is allocated on every render, contributing to unnecessary garbage collection pressure and preventing the browser from caching the style computation.Tier
Tier 2 — Render Performance
Baseline
Before this change,
habit-list-section.tsxcontained 6 static inline style objects:style=\{\{ marginTop: 'var(--base-size-12)' }}(Stack)wrapping action buttonsstyle=\{\{ fontSize: '1.25rem' }}(Heading)"Active Habits"style=\{\{ fontSize: '1.125rem', marginTop: 'var(--base-size-16)' }}(Heading)"No active habits yet"style=\{\{ color: 'var(--fgColor-muted)', marginTop: 'var(--base-size-8)' }}(Text)empty-state descriptionstyle=\{\{ fontSize: '1.25rem' }}(Heading)"Completed Habits"style=\{\{ fontSize: '1.25rem' }}(Heading)"Stopped Habits"All 6 are fully static — the values never change at runtime.
Fix
Added 4 CSS classes to
habits.module.css: