test: add unit tests for API utils and skill prerequisites (Phase 2)#112
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
test: add unit tests for API utils and skill prerequisites (Phase 2)#112github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
- validation-utils.test.ts: 22 tests covering validateObject and validateRequiredString with null/undefined/whitespace/non-string inputs - response-utils.test.ts: 15 tests covering apiSuccess (200), validationErrorResponse (400), and serviceUnavailableResponse (503), including meta inclusion/omission - prerequisites.test.ts: 11 tests covering getNextAchievableSkills: empty profile, foundation skills, prerequisite gating, level exclusion, duplicate skill deduplication (highest level wins), cascading unlocks Closes #55 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Phase 2 test coverage plan from #55.
What's added
src/lib/api/validation-utils.test.ts(22 tests)Covers
validateObjectandvalidateRequiredString:null,undefined, non-string types, non-object typesnullit.eachfor table-driven test casessrc/lib/api/response-utils.test.ts(15 tests)Covers
apiSuccess,validationErrorResponse,serviceUnavailableResponse:success: true/falsefield on all responsesmetaincluded when provided, omitted when notapiSuccesssrc/lib/skills/prerequisites.test.ts(11 tests)Covers
getNextAchievableSkills:beginnerremain achievable,intermediate/advancedare excludednextjsrequiresreact+typescript)Coverage comparison
The 10 pre-existing failures are all in
src/lib/github/client.test.ts(token unavailable in CI) — unchanged.Closes #55