test: add unit tests for API utils and skill prerequisites (Phase 2)#114
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
test: add unit tests for API utils and skill prerequisites (Phase 2)#114github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Add 3 new test files identified in #55: - src/lib/api/validation-utils.test.ts (21 tests) - src/lib/api/response-utils.test.ts (21 tests) - src/lib/skills/prerequisites.test.ts (20 tests) These cover previously untested pure functions in src/lib/api/ and the Knowledge Space Theory logic in src/lib/skills/prerequisites.ts. Total: +62 passing tests (1087 vs 1025 baseline). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
Summary
Phase 2 implementation from the Daily Test Coverage Improver plan. Adds 62 new passing tests across 3 previously untested files.
New Test Files
src/lib/api/validation-utils.test.ts— 21 testsTests
validateObjectandvalidateRequiredStringpure functions:nullreturnedfieldNameinterpolated correctly in error messagesit.eachsrc/lib/api/response-utils.test.ts— 21 testsTests
apiSuccess,validationErrorResponse,serviceUnavailableResponse:success: true/falsein bodysrc/lib/skills/prerequisites.test.ts— 20 testsTests
getNextAchievableSkillsandSKILL_PREREQUISITES:Coverage Comparison
src/lib/api/validation-utils.tssrc/lib/api/response-utils.tssrc/lib/skills/prerequisites.ts