[perf] Replace inline style in Providers root wrapper with CSS module#128
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
[perf] Replace inline style in Providers root wrapper with CSS module#128github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Pull request created: #128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 2 — Render Performance: Eliminate inline style object on root Providers wrapper
Baseline
src/app/providers.tsxcontained this inline style on the root(div)that wraps every page in the application:Because this is a
'use client'component and the object literal is defined inline, JavaScript creates a new object on every render of the Providers tree. This triggers an inline style recalculation in the browser on each re-render, even though the values never change.Fix
Created
src/app/providers.module.csswith a static.appRootCSS class:Then replaced the inline style with a CSS class reference:
Files changed:
src/app/providers.tsx,src/app/providers.module.css(new)