Skip to content

Refactor OpenApiDocumentFactory into separate modules#1144

Merged
christianhelle merged 3 commits into
mainfrom
deepened-factory
Jun 14, 2026
Merged

Refactor OpenApiDocumentFactory into separate modules#1144
christianhelle merged 3 commits into
mainfrom
deepened-factory

fix: apply CodeRabbit auto-fixes

c93ec4b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 14, 2026 in 15s

Quality Gate failed

Annotations

Check failure on line 28 in src/Refitter.Core/DocumentLoader.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename parameter 'openApiPath' to 'path' to match the interface declaration.

See more on https://sonarcloud.io/project/issues?id=christianhelle_refitter&issues=AZ7ISiarixFPtcnbP5DF&open=AZ7ISiarixFPtcnbP5DF&pullRequest=1144

Check warning on line 137 in src/Refitter.Core/DocumentEquivalenceComparer.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'RemoveNullProperties' a static method.

See more on https://sonarcloud.io/project/issues?id=christianhelle_refitter&issues=AZ7ISia1ixFPtcnbP5DG&open=AZ7ISia1ixFPtcnbP5DG&pullRequest=1144

Check failure on line 26 in src/Refitter.Core/DocumentMerger.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 33 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=christianhelle_refitter&issues=AZ7ISiYuixFPtcnbP5DD&open=AZ7ISiYuixFPtcnbP5DD&pullRequest=1144

Check warning on line 197 in src/Refitter.Core/DocumentEquivalenceComparer.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetDefinitionName' a static method.

See more on https://sonarcloud.io/project/issues?id=christianhelle_refitter&issues=AZ7ISia1ixFPtcnbP5DH&open=AZ7ISia1ixFPtcnbP5DH&pullRequest=1144

Check warning on line 71 in src/Refitter.Core/DocumentMerger.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Loops should be simplified using the "Where" LINQ method

See more on https://sonarcloud.io/project/issues?id=christianhelle_refitter&issues=AZ7ISiYuixFPtcnbP5DE&open=AZ7ISiYuixFPtcnbP5DE&pullRequest=1144

Check warning on line 184 in src/Refitter.Core/DocumentEquivalenceComparer.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Loops should be simplified using the "Where" LINQ method

See more on https://sonarcloud.io/project/issues?id=christianhelle_refitter&issues=AZ7ISia1ixFPtcnbP5DI&open=AZ7ISia1ixFPtcnbP5DI&pullRequest=1144

Check warning on line 44 in src/Refitter.Core/DocumentMerger.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one.

See more on https://sonarcloud.io/project/issues?id=christianhelle_refitter&issues=AZ7IaoUQYF4-iXSskvpu&open=AZ7IaoUQYF4-iXSskvpu&pullRequest=1144