[BLD]: fix maturin strip/include-debuginfo conflict - #7640
Open
mayuriphad wants to merge 1 commit into
Open
Conversation
Local maturin dev builds fail with "--include-debuginfo cannot be used with --strip" because the workspace [profile.release] sets debug = 2 with split-debuginfo = "unpacked", which makes maturin auto-pass --include-debuginfo. That collides with strip = true in [tool.maturin]. Disable strip there instead, matching the profile's own intent to keep debug info. Fixes chroma-core#6536
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maturin devfails locally with:Root cause: the workspace
[profile.release]setsdebug = 2withsplit-debuginfo = "unpacked", which makes maturin automatically pass--include-debuginfo. That collides withstrip = trueunder[tool.maturin]inpyproject.toml.Fix: disable
stripin[tool.maturin]so it no longer conflicts with therelease profile's own debug-info settings.
Fixes #6536
Test plan
maturin devno longer errors with the strip/include-debuginfo conflict locally