fix(sysdb): serialize collection deletion with writes - #7643
Open
mikemikimike wants to merge 2 commits into
Open
fix(sysdb): serialize collection deletion with writes#7643mikemikimike wants to merge 2 commits into
mikemikimike wants to merge 2 commits into
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete_collectionused a deferred SQLite transaction whilecreate_collectionalready acquired the write lock immediately. Under concurrent create/delete operations, the delete could read stale state and both requests could report success.This change applies the existing
begin_immediatehelper to collection deletion, serializing the read-modify-write sequence with other collection mutations.Validation
cargo fmt --checkgit diff --checkgoogleapis/googleapis) required bygcloud-gax.