Skip to content

[ENH](wal3): Type append contention - #7653

Open
domenkozar wants to merge 1 commit into
chroma-core:mainfrom
domenkozar:casita/wal3-append-outcome-pinned
Open

[ENH](wal3): Type append contention#7653
domenkozar wants to merge 1 commit into
chroma-core:mainfrom
domenkozar:casita/wal3-append-outcome-pinned

Conversation

@domenkozar

@domenkozar domenkozar commented Aug 28, 2026

Copy link
Copy Markdown

Description

Expose append contention as a structured AppendOutcome instead of requiring callers to interpret LogContention* errors as commit status.

The additive append_with_options_outcome API distinguishes:

  • committed appends
  • durable publication contention
  • retryable contention
  • indeterminate durability

Non-contention failures remain in the existing error path, and the legacy append API remains unchanged. This change applies directly to main and does not depend on #7644 or #7645.

Testing

  • cargo test -p wal3 append_result_preserves_contention_semantics --lib
  • Casita RustFS racing-writer and racing-initializer integration tests

Expose contention durability as a structured append outcome so callers do not have to interpret wal3 error variants as commit status.
@github-actions

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@domenkozar
domenkozar force-pushed the casita/wal3-append-outcome-pinned branch from 3604ecd to 6836372 Compare August 28, 2026 21:09
@domenkozar
domenkozar marked this pull request as ready for review August 28, 2026 21:15

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@domenkozar

Copy link
Copy Markdown
Author

cc @rescrv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant