[ENH](wal3): Type append contention - #7653
Open
domenkozar wants to merge 1 commit into
Open
Conversation
Expose contention durability as a structured append outcome so callers do not have to interpret wal3 error variants as commit status.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
domenkozar
force-pushed
the
casita/wal3-append-outcome-pinned
branch
from
August 28, 2026 21:09
3604ecd to
6836372
Compare
domenkozar
marked this pull request as ready for review
August 28, 2026 21:15
Author
|
cc @rescrv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose append contention as a structured
AppendOutcomeinstead of requiring callers to interpretLogContention*errors as commit status.The additive
append_with_options_outcomeAPI distinguishes:Non-contention failures remain in the existing error path, and the legacy append API remains unchanged. This change applies directly to
mainand does not depend on #7644 or #7645.Testing
cargo test -p wal3 append_result_preserves_contention_semantics --lib